Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big view of profile image #1356

Closed
Simon-Laux opened this issue Jan 16, 2020 · 7 comments · Fixed by #1534
Closed

Big view of profile image #1356

Simon-Laux opened this issue Jan 16, 2020 · 7 comments · Fixed by #1534
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Simon-Laux
Copy link
Member

see https://support.delta.chat/t/big-profile-picture/749/3

@Simon-Laux Simon-Laux added enhancement New feature or request good first issue Good for newcomers labels Jan 16, 2020
@arghac14
Copy link

@Simon-Laux Can I work on this?

@Simon-Laux
Copy link
Member Author

Simon-Laux commented Jan 18, 2020 via email

@arghac14
Copy link

arghac14 commented Jan 18, 2020

@Simon-Laux Yes I'm going for the second option. Can you clarify what do you mean by the existing dialog system?

Also, please assign this to me.

@Jikstra
Copy link
Contributor

Jikstra commented Jan 19, 2020

The existing dialog system lays in src/renderer/components/dialogs. Especially the dialogs/index.js is interesting to understand how it works, but not complicated.

@nicodh
Copy link
Contributor

nicodh commented Jan 19, 2020

Maybe take qrInviteCode Dialog as example:
https://github.com/deltachat/deltachat-desktop/blob/master/src/renderer/components/dialogs/QrInviteCode.js
called with screenContext.openDialog('QrInviteCode', { qrCode })

@Simon-Laux
Copy link
Member Author

@arghac14 Did you already start? I plan to work on the profile view too, so I want to know how whether I can convert it to typescript now or if I should keep it in js and just change the lines I need to change and do the switch to ts after your pr is merged.

@Simon-Laux
Copy link
Member Author

As this is stale I'll clear the assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants