New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big view of profile image #1356
Comments
@Simon-Laux Can I work on this? |
Sure, make sure to write all questions you have regarding the implentation here in this issue, so that we can help you with them.
The current media view expects an attachment object so you can't use that media view, unless you modify it so that it can also take a single file-url to a picture. Or you make a new dialog for showing the profile picture in bigger. If you go for the second option I recommend looking at the existing dialogs to get to know the dialog system.
Am 18. Januar 2020 18:04:29 MEZ schrieb Arghadip Chakraborty <notifications@github.com>:
…
@Simon-Laux Can I work on this?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1356 (comment)
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
@Simon-Laux Yes I'm going for the second option. Can you clarify what do you mean by the existing dialog system? Also, please assign this to me. |
The existing dialog system lays in |
Maybe take qrInviteCode Dialog as example: |
@arghac14 Did you already start? I plan to work on the profile view too, so I want to know how whether I can convert it to typescript now or if I should keep it in js and just change the lines I need to change and do the switch to ts after your pr is merged. |
As this is stale I'll clear the assignment. |
see https://support.delta.chat/t/big-profile-picture/749/3
The text was updated successfully, but these errors were encountered: