Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no context menu on input fields #2047

Closed
r10s opened this issue Jan 12, 2021 · 1 comment · Fixed by #2100
Closed

no context menu on input fields #2047

r10s opened this issue Jan 12, 2021 · 1 comment · Fixed by #2100
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@r10s
Copy link
Member

r10s commented Jan 12, 2021

normally, a right-click in an input field shows a system-context-menu with cut/copy/paste and maybe other system-special things (spell correction etc).

currently, this system-context-menu does not appear - but also, no replacement that may be done by chrome appears.

not sure, if the system-context-menu is doable, however, having a menu with at least "paste" is expected in many workflows. i just checked signal, who are also using electron afaik, and there is a context menu.

maybe there is just a return value from some event handler wrong? so that passing the click to the default handler is skipped?

(tested on macos with delta 1.14.1)

@r10s r10s added the bug Something isn't working label Jan 12, 2021
@Simon-Laux
Copy link
Member

Simon-Laux commented Jan 12, 2021

currently, this system-context-menu does not appear

electron doesn't have one.

looks like maybe electron has a way to use the system menu: https://www.electronjs.org/docs/tutorial/spellchecker, so we could have an option that it used instead of our implementation if available... (we can think about that after upgrading electron, but that's a sidequest this only affects how the context menu will look, probably)

What we need is an catch-all on contextmenu that triggers on input fields and only triggers if the event wasn't handled before. I would appreciate if we find a way for that without calling event.preventDefault() and event.stopPropagation.

related:
#1997 (this issue #2047 is halfway duplicate of this one, this issue talks about all input fields and the other one only about the message input field. I'll close #1997 in favor of this one because it is broader defined)
https://support.delta.chat/t/help-testing-the-upcomming-1-14-x-release/1267/2

@Simon-Laux Simon-Laux changed the title right-click does not work in input fields no context menu on input fields Jan 12, 2021
@Simon-Laux Simon-Laux added the enhancement New feature or request label Jan 12, 2021
@Simon-Laux Simon-Laux self-assigned this Jan 13, 2021
@Simon-Laux Simon-Laux added this to To do in Desktop 1.15 via automation Jan 29, 2021
@Jikstra Jikstra moved this from To do to In progress in Desktop 1.15 Feb 2, 2021
Desktop 1.15 automation moved this from In progress to Done Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Desktop 1.15
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants