Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The QRCode is not scannable with the dark theme #2163

Closed
ghost opened this issue Mar 4, 2021 · 1 comment · Fixed by #2165
Closed

The QRCode is not scannable with the dark theme #2163

ghost opened this issue Mar 4, 2021 · 1 comment · Fixed by #2165
Assignees
Labels
blocker This issue is blocking a new release bug Something isn't working

Comments

@ghost
Copy link

ghost commented Mar 4, 2021

  • Operating System (Linux/Mac/Windows/iOS/Android): GNU/Linux Debian 10
  • Delta Chat Version: 1.15.2
  • Expected behavior: When I have dark mode, I wish I could scan QRCode with my Android smartphone.
  • Actual behavior: Currently, it cannot easily scan it.
  • Steps to reproduce the problem: Set dark mode, menu -> QR code
  • Screenshots:
    bug

I think that in the dark mode, you have to leave white space above and below the QRCode to facilitate the QRCode acquisition.

@r10s
Copy link
Member

r10s commented Mar 4, 2021

thanks for filing the issue! as already mentioned in DC, i can confirm that this qr-code also does not work on my mogo-g while light-mode works (in general, it is a good idea to surround qr-codes with a significant light border in the color of qr-code light).

also i'd like to repeat here, that inverting qr-codes is no option (even if that would look better :) and should generally not be done. dark areas have to stay dark, light areas have to stay light, otherwise you risk that scanners won't work (and they will not, it is no theory :)

@Simon-Laux Simon-Laux added blocker This issue is blocking a new release bug Something isn't working labels Mar 5, 2021
@Simon-Laux Simon-Laux added this to To do in Desktop 1.15 via automation Mar 5, 2021
@Simon-Laux Simon-Laux self-assigned this Mar 5, 2021
Simon-Laux added a commit that referenced this issue Mar 5, 2021
also fix theming of switcher
fixes #2163
Simon-Laux added a commit that referenced this issue Mar 5, 2021
also fix theming of switcher
fixes #2163
Desktop 1.15 automation moved this from To do to Done Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker This issue is blocking a new release bug Something isn't working
Projects
No open projects
Desktop 1.15
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants