Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add images to quotes #2628

Closed
r10s opened this issue Mar 15, 2022 · 0 comments
Closed

add images to quotes #2628

r10s opened this issue Mar 15, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@r10s
Copy link
Member

r10s commented Mar 15, 2022

quotes recently became much more useful by the "jump to quote" feature.

what is still missing, is enriching the quote eg. by the image if an image was quoted.

to get rich content, one should check dc_msg_get_quoted_text() to check if there is a quote at all. if so, use dc_msg_get_quoted_msg() to get the full, quoted message object - that may be null if the message is not availalbe. however, if that is non-null, you can check viewtype and file to get the image as usual.

this is how that looks like on ios - android is similar:

it may also make sense to display other rich content, as documents, however, displaying images have by far the largets impact - so maybe just do that for now and move on to other things with larger impact :)

@Simon-Laux Simon-Laux added enhancement New feature or request good first issue Good for newcomers labels Mar 15, 2022
@Simon-Laux Simon-Laux self-assigned this Apr 28, 2022
Simon-Laux added a commit that referenced this issue Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants