Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stock translations set too late (after I/0 is started) #2735

Closed
r10s opened this issue May 5, 2022 · 0 comments · Fixed by #2743
Closed

stock translations set too late (after I/0 is started) #2735

r10s opened this issue May 5, 2022 · 0 comments · Fixed by #2743
Labels
bug Something isn't working
Projects
1.30: Reliability and Speed Releases

Comments

@r10s
Copy link
Member

r10s commented May 5, 2022 •
edited

in selectAccout() first startIO() and after that _setCoreStrings() is called.

it should be the other way round.

otherwise, if there are pending MDNs, an MDN may be generated in English because the translation is not set yet:
https://support.delta.chat/t/language-of-return-receipts/2075/3

on android and ios, we did the same mistake:
deltachat/deltachat-android#2290
deltachat/deltachat-ios#1569

(i only had a rough look at the code, so, maybe there are more usages of dc_set_stock_translation())
@r10s r10s added the bug Something isn't working label May 5, 2022
@Simon-Laux Simon-Laux added this to To do in 1.30: Reliability and Speed Releases via automation May 8, 2022
Simon-Laux added a commit that referenced this issue May 9, 2022
@Simon-Laux
fix stock translations set too late
54bcfb4 
(after I/0 is started)
closes #2735
@Simon-Laux Simon-Laux mentioned this issue May 9, 2022
Merged
1.30: Reliability and Speed Releases automation moved this from To do to Done May 10, 2022
Simon-Laux added a commit that referenced this issue May 10, 2022
@Simon-Laux
fix stock translations set too late (#2743)
613c61b 
(after I/0 is started)
closes #2735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
1.30: Reliability and Speed Releases
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix stock translations set too late (after I/0 is started) deltachat/deltachat-desktop
1 participant
@r10s