Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webxdc-title should be shown in bold #2774

Closed
r10s opened this issue May 22, 2022 · 2 comments · Fixed by #2780
Closed

webxdc-title should be shown in bold #2774

r10s opened this issue May 22, 2022 · 2 comments · Fixed by #2780
Assignees
Labels

Comments

@r10s
Copy link
Member

r10s commented May 22, 2022

the webxdc-title (and/or maybe the -document, so, the line above the summary) should be shown in bold.

the summary and the other texts are fine as they are now. the webxdc-title/document in the gallery is also already fine.

tested for 1.29.0 - if that is changed meanwhile, please just close this issue.

@r10s r10s added the webxdc label May 22, 2022
@Simon-Laux
Copy link
Member

Simon-Laux commented May 27, 2022

bold looks not so nice, I prefer slightly bigger text:
image
image

bold for comparison:
image
image

or maybe both?:
image

@Simon-Laux Simon-Laux self-assigned this May 27, 2022
Simon-Laux added a commit that referenced this issue May 27, 2022
@r10s
Copy link
Member Author

r10s commented May 28, 2022

bold looks not so nice, I prefer slightly bigger text:

let's go for consistency and stay in sync with android and ios and the desktop gallery which all show the titles in bold.

the bold title also looks more outstanding than just slightly bigger and that seems to be a natural choice here. and it is already a huge improvement.

however, using a slightly bigger font-size in addition ("both", last image) would also be fine wrt consistency. i personally would just go the easy way and use just the same font-size - too many different font-sizes easily look messy when not always having all combinations in mind and testing them.

Simon-Laux added a commit that referenced this issue May 28, 2022
* click on webxdc icon starts it too now
closes #2775

* webxdc title is now shown in bold
closes #2774

* remove context menu option "open attachment" for webxdc
closes #2763

Co-authored-by: Jikstra <34889164+Jikstra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants