mailto link inside webxdc causes blank page

[adbenitez]

[Simon-Laux]

we would need to upgrade electron for this or get rid of the iframe (FILL 500 hack)

[Simon-Laux]

this requires electron 25+

[Simon-Laux]

#3381

[WofWca]

get rid of the iframe (FILL 500 hack)

How would that work? I see that the wrapper is still used in #3381.

It looks to me like this piece of code does nothing, after the introduction of the WebRTC exfiltration mitigation:

deltachat-desktop/src/main/index.ts

Lines 247 to 264 in 853b584

	app.on('web-contents-created', (_ev, contents) => {
	const is_webxdc = contents.session.storagePath?.indexOf('webxdc_') !== -1
	if (is_webxdc) {
	contents.on('will-navigate', (e, navigationUrl) => {
	if (navigationUrl.startsWith('webxdc://')) {
	// allow internal webxdc nav
	return
	} else if (navigationUrl.startsWith('mailto:')) {
	// handle mailto in dc
	e.preventDefault()
	open_url(navigationUrl)
	mainWindow.window?.focus()
	} else {
	// prevent navigation to unknown scheme
	e.preventDefault()
	}
	})
	} else {

Because all navigation is prevented anyway:

deltachat-desktop/src/main/deltachat/webxdc.ts

Lines 367 to 370 in f5f073a

	// prevent reload and navigation of wrapper page
	webxdc_windows.webContents.on('will-navigate', ev => {
	ev.preventDefault()
	})

I might be wrong though.

[Simon-Laux]

We need to either get rid of the frame again or use an electron version that has the "will-frame-navigate" event.

Someone could also attempt to backport the event to electron 22, but that might be to complicated.

[WofWca]

How does "will-frame-navigate" help?

We want an <iframe> because:

• Upon initial load, we want to execute the 500 hack before the app gets a chance to execute its code
• If there is a page reload, we need to make sure to have 500 RTCPeerConnection at all times while the user script is active.

Does the new Electron allow to solve the reload problem?

[Simon-Laux]

How does "will-frame-navigate" help?

It allows us to use the code you mentioned in your previous comment again. Or have I missed something?

[WofWca]

Yeah, for "will-frame-navigate" that's true (I think), but I'm asking about how it's gonna help get rid of the wrapper <iframe>.

[Simon-Laux]

It won't, I said we "either" need one or the other, not both.

[WofWca]

Oh I see.
How does the new Electron version allow to get rid of the 500 hack then?

[Simon-Laux]

How does the new Electron version allow to get rid of the 500 hack then?

no, this is just about the mailto: stuff discussed in this issue.

My communication seems lacks here, please tell me how to improve it.

[WofWca]

Ok, it's my bad, sorry 🤦‍♀️
I read

we would need to upgrade electron for this or get rid of the iframe (FILL 500 hack)

as "for this to get rid". I thought you have an idea of how to get rid of the <iframe>, it's why I keep asking.

[Simon-Laux]

looks like we did not even need the electron upgrade, in the end it was contents.setWindowOpenHandler()