Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some links in full-msg-html-view not working #3408

Closed
r10s opened this issue Sep 18, 2023 · 3 comments · Fixed by #3409
Closed

some links in full-msg-html-view not working #3408

r10s opened this issue Sep 18, 2023 · 3 comments · Fixed by #3409
Labels
bug Something isn't working

Comments

@r10s
Copy link
Member

r10s commented Sep 18, 2023

it happens from time to time to me, that some links are not working in the "Show full message..." view - where the same message's links work on iOS (not tested android in this case)

here is an example as an .eml file: https://gist.github.com/r10s/19f027782070c1688ece74621332dc73 (the 3D= is the quoted printable, core should clean this up for ui), the rendered, not working links look as follows:

thunderbird, apple-mail, delta-chat-ios all work. also, you can copy+paste the link from deltachat-deskop - but you cannot open it.

the mail is generated by https://aktion.campact.de/verkehr/49-euro-ticket/teilnehmen , maybe they're doing sth wrong, however i have seen the issue also before in other contexts, so even then, deltachat-desktop should probably be more graceful

@r10s r10s added the bug Something isn't working label Sep 18, 2023
@Simon-Laux
Copy link
Member

what's your desktop version and what is the link?

@r10s
Copy link
Member Author

r10s commented Sep 18, 2023

what's your desktop version and what is the link?

version is 1.40.1/mac and the link is the "Jetzt unterzeichnen und informiert bleiben" from the image above; the destination is https://aktion.campact.de/verkehr/49-euro-ticket/teilnehmen/v/d9478a66-3c98-4476-9f0b-39bef14d6325?subscribe=1 - the linked .eml above shows the whole source.

i also checked log and dev tools, could not find suspicious things there (i did not see anything regarding the link) - EDIT: @Simon-Laux for easier testing, i also forwarded the message in question to your merlinux address

@Simon-Laux
Copy link
Member

<a
 href="https://aktion.campact.de/verkehr/49-euro-ticket/teilnehmen/v/d9478a66-3c98-4476-9f0b-39bef14d6325?subscribe=1"
 style="display:inline-block;background:#C0000D;color:#ffffff;font-family:Open Sans, Helvetica, Arial, sans-serif;font-size:25px;font-weight:800;line-height:120%;margin:0;text-decoration:none;text-transform:none;padding:13px 20px 16px;mso-padding-alt:0px;border-radius:0;"
 target="_blank">
 Jetzt unterzeichnen und informiert bleiben
</a>

seems like target="_blank" is the issue here, because when I remove that the link works. Maybe this requires a new special event listener in electron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants