Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webxdc title not updated in document title changes #3412

Closed
adbenitez opened this issue Sep 25, 2023 · 1 comment · Fixed by #3422
Closed

webxdc title not updated in document title changes #3412

adbenitez opened this issue Sep 25, 2023 · 1 comment · Fixed by #3422
Assignees
@Simon-Laux
Labels
bug Something isn't working webxdc

Comments

@adbenitez
Copy link
Member

if the app is opened and the document title changes, the title bar is not updated, see deltachat/deltachat-android#2664
@adbenitez adbenitez added bug Something isn't working webxdc labels Sep 25, 2023
@r10s
Copy link
Member

r10s commented Sep 25, 2023 •
edited
Loading

ftr, DC_EVENT_MSGS_CHANGED is emitted and dc_msg_get_webxdc_info() returns the correct information

(the issue on android was that it was called on an outdated dc_msg_t; this does not work in general. desktop, if course, may have other reasons for failure :)

@Simon-Laux Simon-Laux self-assigned this Sep 28, 2023
@Simon-Laux Simon-Laux mentioned this issue Sep 28, 2023
Merged
9 tasks
Simon-Laux added a commit that referenced this issue Sep 29, 2023
@Simon-Laux
fix webxdc title not updated in document title changes
f03a495 
fixes #3412
@Simon-Laux Simon-Laux mentioned this issue Sep 29, 2023
Merged
Simon-Laux added a commit that referenced this issue Sep 29, 2023
@Simon-Laux
fix webxdc title not updated in document title changes (#3422)
7bbe47a 
* fix webxdc title not updated in document title changes

fixes #3412

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simon-Laux Simon-Laux

Labels
bug Something isn't working webxdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix webxdc title not updated in document title changes deltachat/deltachat-desktop
3 participants
@r10s @Simon-Laux @adbenitez