Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"reply" function degraded on master #3540

Closed
r10s opened this issue Nov 17, 2023 · 3 comments · Fixed by #3541
Closed

"reply" function degraded on master #3540

r10s opened this issue Nov 17, 2023 · 3 comments · Fixed by #3541
Assignees
Labels
bug Something isn't working

Comments

@r10s
Copy link
Member

r10s commented Nov 17, 2023

eg. for mailing lists, the "reply" function is no longer available since the attempt to fix #3535 in #3536

reason is that the menu entry is hidden because of chattype instead of checking dc_chat_can_send() - which is also much better in checking other states as contact-request or guaranteed-e2ee-broken

@r10s r10s added the bug Something isn't working label Nov 17, 2023
@adzialocha
Copy link
Member

Oh! Dammit. So mailing lists are actually writable?

dc_chat_can_send()

Where is this method reflected in the Rust implementation, RPC and / or TypeScript wrappers? I can try a deep dive but maybe faster to ask here. @Simon-Laux @r10s

@adzialocha adzialocha self-assigned this Nov 17, 2023
@adzialocha
Copy link
Member

Where is this method reflected in the Rust implementation, RPC and / or TypeScript wrappers? I can try a deep dive but maybe faster to ask here. @Simon-Laux @r10s

Okay, I assume it is canSend on the chat objects

@r10s
Copy link
Member Author

r10s commented Nov 17, 2023

Oh! Dammit.

no worries, you could not have known that, even long-term members are struggling with state of api & co here and there :)

So mailing lists are actually writable?

yes, most times. but there are situation where this is not possible or not wantend, for whatever reason. in these cases can_send() returns false. so UI should not worry about the "why", which may also change over time by adding features or fixing bugs. UI should just use these information. in general, the whole api is meant to be very high level, and serving the UIs concrete needs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants