Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not show reply option in read-only groups #3536

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

adzialocha
Copy link
Member

Closes: #3535

@adzialocha adzialocha marked this pull request as ready for review November 16, 2023 19:03
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Simon-Laux Simon-Laux merged commit 48ac258 into master Nov 16, 2023
8 checks passed
@Simon-Laux Simon-Laux deleted the adz/i3535-disable-reply-in-broadcast-chats branch November 16, 2023 19:49
@r10s
Copy link
Member

r10s commented Nov 16, 2023

@Simon-Laux @adzialocha if not yet done somehow (i looked only at the diff) i think, we should better use dc_chat_can_send() to check if one can reply to a message

eg. there are mailing lists, where one can reply to or you cannot reply to contact request or if protection is broken. replying to broadcast list messages is usually okay for the sender etc. this and more is checked by can_send()

adzialocha added a commit that referenced this pull request Nov 21, 2023
* master: (29 commits)
  fix double message context menu (#3551)
  fix displaying sticker that has wrong mimetype (#3552)
  fix bug where composer was locked after joining a group via qr code (#3547)
  prepare 1.41.3
  comment out verbose logging of store
  add `vi` to appx supported languages let's hope that this does not break the ms store again, it was on the ms list of supported languages, so I hope that it does not break it.
  Update translations (17.11.2023) and add Vietnamese language
  fix translation key for `add_to_sticker_collection` in context menu (#3544)
  fix eslint
  Select device message chat automatically to welcome first users (#3531)
  Improve layout and fix unknown locale of `DisabledMessageInput` (#3537)
  Use `dc_chat_can_send` to show or hide reply functionality (#3541)
  add more debug logging when clearing notifications (#3534)
  update deltachat-node and deltachat/jsonrpc-client to `v1.131.4` (#3539)
  update local help (#3538)
  Fix: Do not show reply option in read-only groups (#3536)
  Update options for disappearing messages (#3530)
  Do not show redundant read-only message when in device messages chat (#3532)
  fix: bug in emoji detection for jumbomoji #3508
  update deltachat-node and deltachat/jsonrpc-client to `v1.131.3`
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reply menu option not disabled in read-only mailing list, draft set
3 participants