Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double context menu #3550

Closed
Simon-Laux opened this issue Nov 20, 2023 · 0 comments · Fixed by #3551
Closed

Double context menu #3550

Simon-Laux opened this issue Nov 20, 2023 · 0 comments · Fixed by #3551
Assignees
@Simon-Laux
Labels
bug Something isn't working

Comments

@Simon-Laux
Copy link
Member

  • Expected behavior: one context menu on right click on message
  • Actual behavior: our and the native context menus on right click on message
  • Steps to reproduce the problem: right click on message
  • Screenshots:
Bildschirmfoto 2023-11-20 um 17 35 34

seems this was introduced by making showMenu in Message.tsx async, this way it forgets to call ev.preventDefault() in 612e8be
@Simon-Laux Simon-Laux added the bug Something isn't working label Nov 20, 2023
@Simon-Laux Simon-Laux self-assigned this Nov 20, 2023
Simon-Laux added a commit that referenced this issue Nov 20, 2023
@Simon-Laux
fix double message context menu #3550
a4db9e9
@Simon-Laux Simon-Laux mentioned this issue Nov 20, 2023
Merged
Simon-Laux added a commit that referenced this issue Nov 21, 2023
@Simon-Laux
fix double message context menu (#3551)
fee1821 
* fix double message context menu #3550

* fmt fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simon-Laux Simon-Laux

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix double message context menu deltachat/deltachat-desktop
1 participant
@Simon-Laux