Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip fill peer connections if webxdc internetAccess is allowed #3844

Open
nicodh opened this issue May 22, 2024 · 4 comments
Open

Skip fill peer connections if webxdc internetAccess is allowed #3844

nicodh opened this issue May 22, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@nicodh
Copy link
Contributor

nicodh commented May 22, 2024

Noneed to prefill all 500 connections if internet access is allowed anyway

@nicodh nicodh added the enhancement New feature or request label May 22, 2024
@nicodh nicodh self-assigned this May 22, 2024
@Simon-Laux
Copy link
Member

webrtc can access anywhere, so no, there is still a need to prefill/disable it.
especially if we want to make these extension-xdc user replaceable.
Also internet access is heavily limited, at least on desktop it only lets requests to openstreetmaps go through.

@hpk42
Copy link
Contributor

hpk42 commented May 27, 2024 via email

@nicodh
Copy link
Contributor Author

nicodh commented Jun 5, 2024

I would suggest to set a list of URLS in the advanced settings which are accessible and set openstreetmap.org as a prefilled default (when location streaming is enabled)
Then it's more transparent which URLs maybe accessed and that openstreetmap.org is provided by default and it is extendable in a transparent way...

@Simon-Laux
Copy link
Member

Simon-Laux commented Jun 6, 2024

my opinion: use the core http api for fetching the tiles + maybe specify allowed domains in the webxdc manifest

@nicodh nicodh removed their assignment Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants