Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show device message only once as unread #3934

Open
r10s opened this issue Jun 12, 2024 · 0 comments
Open

show device message only once as unread #3934

r10s opened this issue Jun 12, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@r10s
Copy link
Member

r10s commented Jun 12, 2024

on switching or adding profiles,
the device messages (welcome and update messages) are added - they are maked as unread even though maybe read already several times, being unnecessary noise, not only for us devs.

we should add them as "read" instead, if they're read in other profiles already.

(this started on android with the idea to not add the messages, however, it turned out that it is easier and less confusing to make the messages as read)

implementation-wise, both, android and ios:

  • check if a global user-setting is equal to the deviceMessageLabel just added
  • if so, the chat is marked as read completely
  • after that, unconditionally, deviceMessageLabel is set

reference implementations: https://github.com/deltachat/deltachat-ios/pull/2204/files, https://github.com/deltachat/deltachat-android/pull/3069/files ("deviecMsgId" should be named "deviceMsgLabel" there cmp)

this issue has low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants