use name deviceMsgLabel as it is a label and no id
#3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
changed the title
deviceMsgLabel as it is a label and no id
r10s
force-pushed
the
r10s/name-label-to-label
branch
from
50e6e67
to
7614774
Compare
|
To test the changes in this pull request, install this apk: |
came over that while targeting deltachat/deltachat-ios#2204 and was shortly confused about what is going on there :) (the name saved to database is not changed, however, to avoid popping up the message again in case we do an update without a new device messase)
r10s
force-pushed
the
r10s/name-label-to-label
branch
from
7614774
to
5da247f
Compare
|
To test the changes in this pull request, install this apk: |
adbenitez
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
came over that while targeting deltachat/deltachat-ios#2204 and was shortly confused about what is going on there :)
(the name saved to database is not changed, however, to avoid popping up the message again in case we do an update without a new device messase)