Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicely view vCards in staging/draft #3940

Closed
Hocuri opened this issue Jun 15, 2024 · 1 comment · Fixed by #3948
Closed

Nicely view vCards in staging/draft #3940

Hocuri opened this issue Jun 15, 2024 · 1 comment · Fixed by #3948
Assignees
@Simon-Laux
Milestone
New composer

Comments

@Hocuri
Copy link

Hocuri commented Jun 15, 2024

Right now (in 1.46.0), when attaching a vCard to a message, this looks like this:
image

I think that this can lead to user confusion, so it would be nice to improve this to show the avatar, name, and email address (just as it looks in messages).

Alternatively, we could simply immediately send out the message without setting it as a draft first. This way, there would be no need to show it as a draft.

See with #3906; ping @nicodh @Simon-Laux
@Simon-Laux Simon-Laux added this to the New composer milestone Jun 15, 2024
@Simon-Laux
Copy link
Member

Simon-Laux commented Jun 15, 2024 •
edited
Loading

Sure could be nice, should also be possible already before composer refactoring.

@Simon-Laux Simon-Laux self-assigned this Jun 17, 2024
Simon-Laux added a commit that referenced this issue Jun 17, 2024
@Simon-Laux
add pretty preview to vcard draft
e16f164 
closes #3940
@Simon-Laux Simon-Laux mentioned this issue Jun 17, 2024
Merged
Simon-Laux added a commit that referenced this issue Jun 17, 2024
@Simon-Laux
add pretty preview to vcard draft
4bb7b75 
closes #3940
Simon-Laux added a commit that referenced this issue Jun 17, 2024
@Simon-Laux
add pretty preview to vcard draft (#3948)
4c7205f 
* add pretty preview to vcard draft

closes #3940

* Add pr number to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simon-Laux Simon-Laux

Labels
None yet
Projects
None yet
Milestone
New composer
Development

Successfully merging a pull request may close this issue.

add pretty preview to vcard draft deltachat/deltachat-desktop
2 participants
@Hocuri @Simon-Laux