Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize the composer based on the newlines in the text #654

Merged
merged 12 commits into from
Feb 1, 2019
Merged

Resize the composer based on the newlines in the text #654

merged 12 commits into from
Feb 1, 2019

Conversation

Jikstra
Copy link
Contributor

@Jikstra Jikstra commented Feb 1, 2019 •
edited
Loading

screenshot_20190131_162940

Still missing:

  • emoji picker isn't at the right position currently
  • resizing isn't on point yet
  • we sometimes have scrollbars even if we don't need them
  • composer buttons should stick to the bottom (position them absolutely)
  • some weird css bugs if we're havent selected a chat yet
  • resizing composer is getting called too often

Fixes #543

@Jikstra Jikstra changed the title Feat implement multiline composer2 Resize the composer based on the newlines in the text Feb 1, 2019
ralphtheninja
ralphtheninja requested changes Feb 1, 2019
View reviewed changes
src/renderer/components/ChatView.js
@@ -87,7 +91,7 @@ class ChatView extends React.Component {
this.lastId = this.props.chat.id
this.previousScrollHeightMinusTop = null

this.composerRef = React.createRef()
this.conversationRef = React.createRef()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks setting focus on the composer, used in SplittedChatListAndView.js.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Simon-Laux

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to just do the focus() stuff in componentDidMount() of the ChatView Component?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that works, do it.

@Jikstra
Copy link
Contributor Author

Jikstra commented Feb 1, 2019

Just found a bug with the three dots menu, the top part is hidden. I'm trying to fix it.

@ralphtheninja ralphtheninja merged commit 5fc50a8 into master Feb 1, 2019
@ralphtheninja ralphtheninja deleted the feat_implement_multiline_composer2 branch February 1, 2019 23:16
@WofWca WofWca mentioned this pull request Apr 9, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simon-Laux Simon-Laux Simon-Laux left review comments

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jikstra @ralphtheninja @Simon-Laux