Fix theming issues #1072
Merged
Fix theming issues #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the emoji menu might need some work, too |
|
it an svg, we can change the stroke color somehow in code, and when it is too difficult we can add an alternative image that is inverted |
evlli
commented
Oct 24, 2019
Comment on lines
35
to
47
| border-bottom: 1px solid var(--emojiMartBorder); | ||
| background: var(--emojiMartBg); | ||
| border-top-left-radius: var(--emojiMartOutsideRadius); | ||
| border-top-right-radius: var(--emojiMartOutsideRadius); | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
This Made the a merge conflict. delete neither and just put this in between
There was a problem hiding this comment.
try to rebase your branch to master
Simon-Laux
reviewed
Oct 24, 2019
Simon-Laux
force-pushed
the
themingAdventures
branch
from
56d06fb
to
bad0dd3
Compare
evlli
force-pushed
the
themingAdventures
branch
from
bad0dd3
to
65a1ee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
closes #965