Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve problem of exceptions on quit. fix #2201 #3335

Merged
merged 1 commit into from
Aug 4, 2023
Merged

solve problem of exceptions on quit. fix #2201 #3335

merged 1 commit into from
Aug 4, 2023

Conversation

farooqkz
Copy link
Collaborator

This fixes #2201

@farooqkz farooqkz marked this pull request as ready for review July 31, 2023 11:07
Simon-Laux
Simon-Laux approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, did not test it though

@gerryfrancis gerryfrancis removed their request for review July 31, 2023 12:38
@farooqkz
Copy link
Collaborator Author

farooqkz commented Aug 1, 2023

@Simon-Laux @gerryfrancis Merge?

@Simon-Laux
Copy link
Member

you can merge it after a rebase

@farooqkz
Copy link
Collaborator Author

farooqkz commented Aug 4, 2023

you can merge it after a rebase

after several tries and force push, I noticed a rebase is not needed :)

@farooqkz farooqkz merged commit b9e3662 into deltachat:master Aug 4, 2023
6 checks passed
@farooqkz farooqkz deleted the i2201 branch August 4, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simon-Laux Simon-Laux Simon-Laux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught exception after quitting
2 participants
@farooqkz @Simon-Laux