Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simon/i3473 fix autocrypt setup dialog #3549

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Nov 19, 2023

  • autocrypt setup dialog handle & show error, remove spinner, refactor (unify components)
  • remove blueprint js dependency from autocrypt setup enter key dialog
  • code-cleanup
Bildschirmfoto 2023-11-19 um 01 08 14

now shows the error.

close #3473

@Simon-Laux Simon-Laux requested a review from r10s November 19, 2023 00:18
@Simon-Laux Simon-Laux added the bug Something isn't working label Nov 20, 2023
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested a bad transfer as well as a good transfer - works as expected to me, nice!

cannot say much to the code, however, but lgtm :)

@Simon-Laux Simon-Laux merged commit 7282696 into master Nov 21, 2023
7 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3473-fix-autocrypt-setup-dialog branch November 21, 2023 20:21
adzialocha added a commit that referenced this pull request Nov 27, 2023
* master:
  prepare 1.42.1
  update deltachat-node and deltachat/jsonrpc-client to `v1.131.7` (#3564)
  prepare 1.42 (#3560)
  fix clear chat sometimes not refreshing the messagelist
  prepare 1.41.4
  Update translations (2023-11-22) (#3556)
  update deltachat-node and deltachat/jsonrpc-client to `v1.131.6`
  simon/i3473 fix autocrypt setup dialog (#3549)
  update deltachat-node and deltachat/jsonrpc-client to `v1.131.5` (#3554)
  focus after loading draft fixes 2 issues (#3548)
  update local help (#3553)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong autocrypt setup code does not show error
2 participants