Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update releases workflow document #3685

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Conversation

adzialocha
Copy link
Member

No description provided.

Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good. I have 2 things to add:

uploading a release to GitHub:

run this in a new empty folder as soon as all versions are available on https://download.delta.chat/desktop/:

export dcversion=v1.42.2
wget -r --no-parent -l1 --reject html https://download.delta.chat/desktop/$dcversion
rm download.delta.chat/desktop/$dcversion/*index.html*
gh release upload -R deltachat/deltachat-desktop $dcversion download.delta.chat/desktop/$dcversion/*

Release Progress issue

When making a real release make a new issue following this template to track the status of the release:

- [ ] website ()
- [ ] flathub ()
- [ ] github release ()
     - [ ] downloadable files also on github
- [ ] Mac store ()
- [ ] windows store ()
- [ ] homebrew
- [ ] aur
- [ ] nix ()
- [ ] (community) snap ()

example issue: #3582

docs/RELEASE_WORKFLOW.md Outdated Show resolved Hide resolved
docs/RELEASE_WORKFLOW.md Outdated Show resolved Hide resolved
docs/RELEASE_WORKFLOW.md Outdated Show resolved Hide resolved
docs/RELEASE_WORKFLOW.md Outdated Show resolved Hide resolved
@adzialocha adzialocha marked this pull request as ready for review February 14, 2024 15:46
@r10s
Copy link
Member

r10s commented Feb 14, 2024

nb: what about moving the document to /RELEASE.md - that location seems to be more common in general -
and in special it is consistent with deltachat-core - android and ios also recently changed location of their release checklist (deltachat/deltachat-android#2867, deltachat/deltachat-ios#1985)

@Simon-Laux
Copy link
Member

maybe it still makes sense to mention the trick/commands to automate uploading the releases to the GitHub release. but besides that I think it's ready to merge, already much better than before, thanks for updating it 👍

@adzialocha adzialocha merged commit e1d6af7 into master Feb 19, 2024
2 checks passed
@adzialocha adzialocha deleted the adz/update-release-workflow branch February 19, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants