Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor QR code reader #3762

Merged
merged 46 commits into from
Apr 23, 2024
Merged

Refactor QR code reader #3762

merged 46 commits into from
Apr 23, 2024

Commits on Apr 19, 2024

  1. Introduce new QrReader component with quircs

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d6c9d11 View commit details
    Browse the repository at this point in the history

  2. Try zxing-wasm library

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8d7bc18 View commit details
    Browse the repository at this point in the history

  3. Allow selecting different cameras and modes

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    43dee16 View commit details
    Browse the repository at this point in the history

  4. Add options to scan from image or clipboard

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    83ad538 View commit details
    Browse the repository at this point in the history

  5. Remove handleError from camera to avoid reloading

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    00a8849 View commit details
    Browse the repository at this point in the history

  6. Use pointer cursor on qr code dialog tabs

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    234ad9d View commit details
    Browse the repository at this point in the history

  7. Use zbar-wasm

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    812a9a9 View commit details
    Browse the repository at this point in the history

  8. Add CHANGELOG.md entry

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    431e895 View commit details
    Browse the repository at this point in the history

  9. Make icon a little larger, improve styling

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d79763b View commit details
    Browse the repository at this point in the history

  10. Remove selecting facing mode, bring cameras into root of context menu

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8a7501a View commit details
    Browse the repository at this point in the history

  11. Read image from clipboard

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    20bdf64 View commit details
    Browse the repository at this point in the history

  12. Move handling scan results into own method

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    27e2f91 View commit details
    Browse the repository at this point in the history

  13. Use translation strings

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2c87ade View commit details
    Browse the repository at this point in the history

  14. Hide camera selection when only one camera is given

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d15ef23 View commit details
    Browse the repository at this point in the history

  15. Update CHANGELOG.md

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    836dcd9 View commit details
    Browse the repository at this point in the history

  16. Bring back former styling

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7e442a6 View commit details
    Browse the repository at this point in the history

  17. Adjust button position a little

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    e07dfcf View commit details
    Browse the repository at this point in the history

  18. Do not show hint on error

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2c0b404 View commit details
    Browse the repository at this point in the history

  19. Remove unused npm dependency

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    462c1bb View commit details
    Browse the repository at this point in the history

  20. Improve error message

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5389a4f View commit details
    Browse the repository at this point in the history

  21. Handle empty base64 string when reading clipboard image from electron

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c14da78 View commit details
    Browse the repository at this point in the history

  22. Remove duplicate button

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a942405 View commit details
    Browse the repository at this point in the history

  23. Docstring for readClipboardImage method

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a04ed95 View commit details
    Browse the repository at this point in the history

  24. Use checkmark icon which works in darkmode as well

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    90b4d6f View commit details
    Browse the repository at this point in the history

  25. Flip video horizontally

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d600218 View commit details
    Browse the repository at this point in the history

  26. Improve styling for longer error message

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3696c46 View commit details
    Browse the repository at this point in the history

  27. Add a whole bunch of comments

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c4358a3 View commit details
    Browse the repository at this point in the history

  28. Automatically select first available video device

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    919bffa View commit details
    Browse the repository at this point in the history

  29. Reset input element to still receive onChange when selecting same image

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    655eff1 View commit details
    Browse the repository at this point in the history

  30. Always flip processing flag, in error or success cases

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    edaba32 View commit details
    Browse the repository at this point in the history

  31. Fix removed subtitle prop in other components

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    67fe777 View commit details
    Browse the repository at this point in the history

  32. Fix confirm dialog not returning callback on ESC-key events

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    31c0955 View commit details
    Browse the repository at this point in the history

  33. Use isEmpty method on NativeImage

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    db005ec View commit details
    Browse the repository at this point in the history

  34. Show error when no data was found in selected image file

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    399e192 View commit details
    Browse the repository at this point in the history

  35. Leave a note to change translation string

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    db1294d View commit details
    Browse the repository at this point in the history

  36. Correct JSX comment syntax

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5f2663e View commit details
    Browse the repository at this point in the history

  37. Use jsqr for now as zbar-wasm seems to be too unstable

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    63fcfb0 View commit details
    Browse the repository at this point in the history

  38. Already use untranslated string

    @adzialocha
    adzialocha committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    09ecf86 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Increase scan interval to 250ms

    @adzialocha
    adzialocha committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    7229f83 View commit details
    Browse the repository at this point in the history

  2. Close dialog after cancelling

    @adzialocha
    adzialocha committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    d150792 View commit details
    Browse the repository at this point in the history

  3. Better name for method

    @adzialocha
    adzialocha committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    b73d329 View commit details
    Browse the repository at this point in the history

  4. Make stopping stream logic more robust for different cases

    @adzialocha
    adzialocha committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    67c4792 View commit details
    Browse the repository at this point in the history

  5. Use worker

    @adzialocha
    adzialocha committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    eb6ffbe View commit details
    Browse the repository at this point in the history

  6. Keep showing QR reader when cancelling dialogs

    @adzialocha
    adzialocha committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    8ffe6e3 View commit details
    Browse the repository at this point in the history

  7. Do not display progress bar when processing code

    @adzialocha
    adzialocha committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    cebe9ef View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Update src/renderer/components/QrReader/index.tsx 

    Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>
    @adzialocha @Simon-Laux
    adzialocha and Simon-Laux committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b80e73b View commit details
    Browse the repository at this point in the history