Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up pr to instant onboarding & add as second device scanner improvements #3801

Merged
merged 14 commits into from
May 2, 2024

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented May 1, 2024

closes #3676
closes #3803

also fixes opening chat after secure join
@Simon-Laux Simon-Laux marked this pull request as ready for review May 1, 2024 01:14
@Simon-Laux Simon-Laux requested a review from r10s May 1, 2024 03:44
@r10s
Copy link
Member

r10s commented May 1, 2024

thanks a lot for taking care! ❤️

some high-level comments:

  • it seems fine to regard the "My Profile" screen as a confirmation dialog, indeed, nothing has happend if the user taps "back". thanks for thinking that over!

  • the new "troubleshooting" button is fine, indeed, as you said, "more options" is gone, so it's better to have that directly there

  • for the new anchor #multiclient-troubleshooting vs. #multiclient, regarding the current help wordings, i do not think it is necessarily an improvement. if you do not know much about "add as second device" at all, a little introduction is needed, and counts to troubleshooting as well. even if the headline is not literally correct, the "Troubleshooting" immediately follows. maybe we should have named the button just "Help" or organise the paragraphs differently.

    for the sake of ease and consistency, however, for now, let's stay with the anchor. at some point we will iterate over the section anyways (iroh update?), no need to change things before (also as adding anchors adds noise to translations etc.)
    esp, as there was just nothing before :)

  • for the "add second device" screen, i'd unclutter the above area as follows:

       

@Simon-Laux Simon-Laux changed the title follow up pr to instant onboarding follow up pr to instant onboarding & add as second device scanner improvements May 1, 2024
@Simon-Laux
Copy link
Member Author

Sure the troubleshooting section is visible, but not that much, otherwise I wouldn't have raised it as an issue:
Bildschirmfoto 2024-05-02 um 00 13 20

Though we can say that people looking for it will surely find it (provided the other sections above it do not grow too much (content updates and. other languages might need less or more characters/space to express the concepts).

About renaming to "help", I wouldn't do that because of the following reasoning: To give some stereotype, some group of people try around stuff and would never "read the manual" first. I have the feeling that the word "troubleshooting" is less of a problem than admitting to needing "help" for those people. (I personally also have that tendency of trying out things before reading the manual, though I don't know if that is an effect of genetics/biology, my soul, the society/patriarchy or whatever).
But my position on this aspect is debatable, you could also argue that more people want assistant to understand what second device setup is at all, though I doubt that many people would stumble across that dialog by accident.

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is very nice improvement wrt layout and functionality now 👌

code lgtm - as far as i can tell :)

CHANGELOG.md Outdated Show resolved Hide resolved
src/renderer/hooks/useInstantOnboarding.ts Outdated Show resolved Hide resolved
Simon-Laux and others added 2 commits May 2, 2024 13:01
Co-authored-by: bjoern <r10s@b44t.com>
Co-authored-by: bjoern <r10s@b44t.com>
@Simon-Laux Simon-Laux merged commit 69f3a76 into master May 2, 2024
4 of 6 checks passed
@Simon-Laux Simon-Laux deleted the simon/instant-onboarding-followup branch May 2, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help does not open for missing languages DCLOGIN broken when logged in windows: add-second-device issues
2 participants