Lazy-load contacts #3927
Merged
Lazy-load contacts #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no objections so far. |
|
Is this PR ready for review? If yes, why is it a draft? |
|
No, not ready. Draft because it's not done yet. Need to clean up, and change a few more places. |
Alright. Looking forward to it! |
WofWca
force-pushed
the
wofwca/contacts-infinite-loader
branch
2 times, most recently
from
b24f915
to
0b8174f
Compare
WofWca
force-pushed
the
wofwca/contacts-infinite-loader
branch
from
aa7efa5
to
ceed14c
Compare
1 task
And add docstring mentioning performance
and `useContactIds`
The approach (`useMemo()`) is the same as in `CreateGroup` a few lines above Although this doesn't really affect real-life scenarios, because on initial load the list is empty anyway, and when recipients are added, the contacts are already loaded
Simon-Laux
force-pushed
the
wofwca/contacts-infinite-loader
branch
from
ceed14c
to
8a100c0
Compare
Simon-Laux
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easier to review the changes commit-by-commit (also I'd prefer "rebase and merge" instead of "squash"). Also, for the last commit, GitHub is not good at showing whitespace-only changes, which it mostly is.
I did a bit of QA (but maybe not enough), and looked at the code. It doesn't look like anything should break.
TODO:
<InfiniteLoader>needs to be added. For now I just want to show the general approach and see if anyone has objections to it.Invalid list ref; please refer to InfiniteLoader documentation.in the console. I think we might need to set it on<AutoSizerinstead? not sure. Should not be a blocker for reviews. Update: solved by putting<FixedSizeListas a direct child of<InfiniteLoader