Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to last-minute instant-onboarding changes #2170

Closed
10 tasks done
r10s opened this issue May 19, 2024 · 0 comments · Fixed by #2176
Closed
10 tasks done

adapt to last-minute instant-onboarding changes #2170

r10s opened this issue May 19, 2024 · 0 comments · Fixed by #2176
Assignees
Labels
enhancement actually in development, user visible enhancement

Comments

@r10s
Copy link
Member

r10s commented May 19, 2024

deltachat/deltachat-android#3060, deltachat/deltachat-android#3064, deltachat/deltachat-android#3068 are the outcome of one-to-one discussions during the current gathering; see there fore reasoning and discussion.

in summary, the following changes are needed in onboarding:

  • pull translations
  • create a regular secondary button with the string Use Other Server (instant_onboarding_show_more_instances) below "Agree & Create Profile"
  • on tapping Use Other Server, an action sheet with the following options should open:
    • List Chatmail Servers (instant_onboarding_other_server) - do the same as "Explore Other Options" before
    • Classic E-Mail Login (manual_account_setup_option) - do the same as "I Already Have A Login / Manual Login" before
    • Scan Invitation Code (scan_invitation_code) - do the same a "Scan QR Code" before
  • remove the lower two buttons "Explore Other Options" and "Scan QR Code"
  • remove "I Already Have A Login / Manual Login" (options left are "Add as Second Device" and "Restore From Backup") (from WelcomeViewController)

the following changes are needed in "New Chat":

  • rename "Scan QR Code" to New Contact (menu_new_contact)
  • rename "New Contact" to Add Contact Manually (menu_new_classic_contact); and hide it when isChatmail() is true

the following changes are needed in "Scan QR" view controller:

  • add Add Contact Manually (menu_new_classic_contact) to the three-dot-menu and open the old manual contact adding activity

in manual contact adding activity:

  • use the title Add Contact Manually (menu_new_classic_contact)
  • add the hint new_classic_contact_explain below the input fields
@r10s r10s added the enhancement actually in development, user visible enhancement label May 19, 2024
@zeitschlag zeitschlag self-assigned this May 21, 2024
zeitschlag added a commit that referenced this issue May 22, 2024
... and fix build. Don't be tired and program
zeitschlag added a commit that referenced this issue May 22, 2024
zeitschlag added a commit that referenced this issue May 22, 2024
r10s pushed a commit that referenced this issue May 27, 2024
r10s pushed a commit that referenced this issue May 27, 2024
r10s pushed a commit that referenced this issue May 27, 2024
... and fix build. Don't be tired and program
r10s pushed a commit that referenced this issue May 27, 2024
r10s pushed a commit that referenced this issue May 27, 2024
r10s pushed a commit that referenced this issue May 27, 2024
r10s pushed a commit that referenced this issue May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement
Projects
Development

Successfully merging a pull request may close this issue.

2 participants