give instructions how to play unsupported video formats #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
show-video-error
branch
3 times, most recently
from
6e66dd1
to
bbc3252
Compare
reduce code complexity and save one message load from database
r10s
force-pushed
the
show-video-error
branch
from
bbc3252
to
4f9a7fc
Compare
…preview (with high chance, Preview won't be able to play it)
r10s
force-pushed
the
show-video-error
branch
from
fdff630
to
87e778a
Compare
r10s
changed the title
r10s
force-pushed
the
show-video-error
branch
from
db3b9c0
to
34ab27a
Compare
r10s
added a commit
that referenced
this pull request
Nov 23, 2023
the idea to show some additional information about how to play a video in case the thumbnail could not be generated was good - however, the detection was just wrong :) this pr tracks correctly if a thumbnail is a real video thumbnail or just a placeholder - in the latter case, the information of #1941 is shown
r10s
added a commit
that referenced
this pull request
Nov 24, 2023
the idea to show some additional information about how to play a video in case the thumbnail could not be generated was good - however, the detection was just wrong :) this pr tracks correctly if a thumbnail is a real video thumbnail or just a placeholder - in the latter case, the information of #1941 is shown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this first commit reduces unneeded code complexity and removes one full message-db load.
the second commit shows an alert with instructions in case a video-preview could not be generated (with high chance, also Preview will fail to play the file)
closes #1909
of course, this can be improved further, however, regarding that .webm video is not an officially supported format, this seems good enough and already a good improvement, giving the ppl an idea how to play that at all (it was not even clear to me :)