align options ephemeral options to android/desktop for consistency #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
commented
Nov 26, 2023
| static let fiveMinutes = 5 * 60 | ||
| static let thirtyMinutes = 30 * 6 | ||
| static let thirtyMinutes = 30 * 60 |
There was a problem hiding this comment.
thirtyMinutes was wrongly defined before, however also not used (neither by ephemeral nor by mute)
r10s
commented
Nov 26, 2023
| @@ -32,7 +32,20 @@ class EphemeralMessagesViewController: UITableViewController { | |||
| self.dcContext = dcContext | |||
| self.chatId = chatId | |||
| super.init(style: .grouped) | |||
| self.currentIndex = self.options.index(of: dcContext.getChatEphemeralTimer(chatId: chatId)) ?? 0 | |||
|
|
|||
| // select option close to the timespan (that may no be available as an option eg. in case option have changed) | |||
There was a problem hiding this comment.
this is the same what we're doing on android, and it seems to be good enough, esp. as this is only for cornercases as removed options - and most chat members do not tweak this option anyways
Simon-Laux
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2000