Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rust to 1.77 #2123

Merged
merged 1 commit into from
Apr 4, 2024
Merged

bump rust to 1.77 #2123

merged 1 commit into from
Apr 4, 2024

Conversation

r10s
Copy link
Member

@r10s r10s commented Mar 23, 2024

@zeitschlag bumping rust to 1.77 requires a lipo update with
cargo install cargo-lipo
due to a recent change with cargo metadata,
see TimNN/cargo-lipo#61

(i ran the update from directory deltachat-ios/libraries/deltachat-core-rust/ not sure of that matters.
update should say
Replaced package 'cargo-lipo v3.2.0' with 'cargo-lipo v3.3.0' on success)

for me, building then succeeds in the simulator as well as on real phones.

closes #2121

bumping rust to 1.77 requires a lipo update with
`cargo install cargo-lipo`
due to a recent change with cargo metadata,
see TimNN/cargo-lipo#61

(update should say
`Replaced package 'cargo-lipo v3.2.0' with 'cargo-lipo v3.3.0'`
on success)
@r10s r10s requested review from zeitschlag and link2xt March 23, 2024 12:01
@r10s r10s added the build build and release related issues label Mar 23, 2024
@r10s r10s removed the request for review from zeitschlag April 2, 2024 10:53
@r10s r10s added the PR waiting for core PR is waiting for core release label Apr 2, 2024
@link2xt
Copy link
Contributor

link2xt commented Apr 4, 2024

Not sure why it is marked as "waiting for core". If it works, can be merged already.

@r10s
Copy link
Member Author

r10s commented Apr 4, 2024

Not sure why it is marked as "waiting for core". If it works, can be merged already.

i was not sure if we do the bump or if some other OS is standing in the way of it. then, let's merge :)

@zeitschlag: next checkout, remind the instructions of this pr

@r10s r10s removed the PR waiting for core PR is waiting for core release label Apr 4, 2024
@r10s r10s merged commit 5947e2e into main Apr 4, 2024
@r10s r10s deleted the r10s/bump-rust-toolchain-to-1.77 branch April 4, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build and release related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try to bump rust toolchain to 1.77
2 participants