Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll ChatList to top if already visible (#2125) #2127

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Scroll ChatList to top if already visible (#2125) #2127

merged 4 commits into from
Mar 27, 2024
+39 −22

Conversation

zeitschlag
Copy link
Collaborator

@zeitschlag zeitschlag commented Mar 26, 2024 •
edited by r10s
Loading

closes #2125

@zeitschlag zeitschlag requested a review from r10s March 26, 2024 16:51
@zeitschlag zeitschlag marked this pull request as ready for review March 26, 2024 16:51
@zeitschlag zeitschlag changed the title Scroll ChatList to top if tapped twice (#2125) Scroll ChatList to top if already visible (#2125) Mar 26, 2024
@r10s r10s added the enhancement actually in development, user visible enhancement label Mar 27, 2024
r10s
r10s approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice improvement!

and thanks for cleaning up namings & co 🧹

deltachat-ios/Coordinator/AppCoordinator.swift Show resolved Hide resolved
@zeitschlag @r10s
Update deltachat-ios/Coordinator/AppCoordinator.swift
b0a9845 
Co-authored-by: bjoern <r10s@b44t.com>
@zeitschlag zeitschlag merged commit 7253503 into main Mar 27, 2024
@zeitschlag zeitschlag deleted the 2125-scroll-to-top branch March 27, 2024 16:18
@r10s r10s mentioned this pull request Apr 6, 2024
Merged
r10s added a commit that referenced this pull request Jul 16, 2024
@r10s
when tapping 'Chats' multiple times, end search
98b8739 
when tapping 'Chats' when chats is already selected,
the gist is to bring the view into kind of default -
so that you see eg. the messages annonced by a badge counter.

PR #2127 did a scroll-to-top for this purpose,
this PR additionally ends search.
@r10s r10s mentioned this pull request Jul 16, 2024
Merged
r10s added a commit that referenced this pull request Jul 16, 2024
@r10s
when tapping 'Chats' multiple times, end search
e78ce48 
when tapping 'Chats' when chats is already selected,
the gist is to bring the view into kind of default -
so that you see eg. the messages annonced by a badge counter.

PR #2127 did a scroll-to-top for this purpose,
this PR additionally ends search.
r10s added a commit that referenced this pull request Jul 16, 2024
@r10s
when tapping 'Chats' multiple times, end search
d05bb32 
when tapping 'Chats' when chats is already selected,
the gist is to bring the view into kind of default -
so that you see eg. the messages annonced by a badge counter.

PR #2127 did a scroll-to-top for this purpose,
this PR additionally ends search.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees
No one assigned
Labels
enhancement actually in development, user visible enhancement
Projects
No open projects
1.46.0 - Instant Onboarding - May Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subsequent taps on "Chats" should scroll up
2 participants
@zeitschlag @r10s