always show the selected reaction in menu #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a reaction was selected, show that instead of "...". this is what whatsapp/signal are doing - as well as deltachat android since deltachat/deltachat-android#2979 deltachat desktop has more room and shows "..." and selection the same time. little drawback is that changing a reaction requires two taps, but that seems fine in practise and is outweighted by advantages as: - always seeing what was selected - make it clearer, there is only one reaction - make it clearer how to retract ones reaction - retracting is always only one tap - consistency
r10s
force-pushed
the
r10s/show-selected-random-reaction
branch
from
27d0f0f
to
b8f41ec
Compare
adbenitez
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
best reviewed without whitespace
if a reaction was selected,
this PR show that instead of "...".
this is what whatsapp/signal are doing - as well as deltachat android since
deltachat/deltachat-android#2979
deltachat desktop has more room and shows "..." and selection the same time.
little drawback is that changing a reaction to another random one requires two taps, but that seems fine in practise and is outweighted by advantages as: