Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second Attempt at "Long Press to ask user to copy link" / Link-"context menu" #2155

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Simon-Laux
Copy link
Member

  • detect long tap on link (I finally found out how to do it 馃帀 )
  • add an action sheet

This still is a draft with probably rather bad code, but it already works.

  • only works on iOS 13+ but I think thats ok
  • I don't really like my time-based-workaround against false triggers of the normal tap handler.
  • A. Would be cool to also use the ios context menu instead of the action sheet, but there is no real link element, it's just part of the UILabel, so probably complicated to make it look good
  • B. or as an alternative to A we could also copy the design of the "copy link sheet" from whatsapp, it seems to be similar to the safari tab switcher or our account switcher.
  • The jumping around of the message list when the sheet opens is not nice to look at

Optional:

  • add small haptic feedback when opening the action sheet, that would already be included with A.
  • Add a option to copy to phone numbers, maybe also a "create phone contact" action

Disclaimer: This is just me playing around because I want this feature (https://support.delta.chat/t/copy-a-link-from-a-message-on-long-press-in-ios/2755).
It is not currently a project priority.

@Simon-Laux Simon-Laux changed the title Seccond Attempt at Long Press to ask user to copy link / Link "context menu" Second Attempt at "Long Press to ask user to copy link" / Link-"context menu" Apr 17, 2024
I also needed a weird workaround against false triggers of the normal tap handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant