Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Commit

Permalink
chore: remove deprecated imap_folder 💥
Browse files Browse the repository at this point in the history
  • Loading branch information
ralphtheninja committed Jun 4, 2019
1 parent 21ad3f2 commit 4329aad
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ The `options` object takes the following properties:
- `options.send_pw` _(string, optional)_: SMTP-password, guessed if left out.
- `options.send_port` _(string | integer, optional)_: SMTP-port, guessed if left out.
- `options.server_flags` _(integer, optional)_: IMAP-/SMTP-flags as a combination of DC_LP flags, guessed if left out.
- `options.imap_folder` _(string, optional)_: IMAP folder to use, defaults to `'INBOX'`.
- `options.displayname` _(string, optional)_: Own name to use when sending messages. MUAs are allowed to spread this way e.g. using CC, defaults to empty.
- `options.selfstatus` _(string, optional)_: Own status to display e.g. in email footers, defaults to a standard text.
- `options.selfavatar` _(string, optional)_: File containing avatar.
Expand Down
1 change: 0 additions & 1 deletion lib/deltachat.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ class DeltaChat extends EventEmitter {
this.setConfig('send_port', String(opts.send_port))

this.setConfig('server_flags', String(opts.server_flags))
this.setConfig('imap_folder', opts.imap_folder)
this.setConfig('displayname', opts.displayname)
this.setConfig('selfstatus', opts.selfstatus)
this.setConfig('selfavatar', opts.selfavatar)
Expand Down
1 change: 0 additions & 1 deletion test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ tape('static getSystemInfo()', t => {
})

test('basic configuration', (t, dc, cwd) => {
t.is(dc.getConfig('imap_folder'), 'INBOX', 'default imap folder')
t.is(dc.getConfig('e2ee_enabled'), '1', 'e2eeEnabled correct')
t.is(
dc.getBlobdir(),
Expand Down
4 changes: 1 addition & 3 deletions test/integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,15 @@ function configureDefaultDC (dc) {
// 4. test opening an already configured account (re-open above)

test('setUp dc context', t => {
t.plan(15)
t.plan(13)
const cwd = tempy.directory()
dc = new DeltaChat()
t.is(dc.getConfig('imap_folder'), 'INBOX', 'default imap folder')
dc.once('ready', () => {
t.is(dc.getConfig('addr'), ADDR, 'addr correct')
t.is(dc.getConfig('mail_server'), SERVER, 'mailServer correct')
t.is(dc.getConfig('mail_user'), ADDR, 'mailUser correct')
t.is(dc.getConfig('send_server'), SERVER, 'sendServer correct')
t.is(dc.getConfig('send_user'), ADDR, 'sendUser correct')
t.is(dc.getConfig('imap_folder'), 'INBOX', 'default imap folder')
t.is(dc.getConfig('displayname'), 'Delta One', 'displayName correct')
t.is(dc.getConfig('selfstatus'), 'From Delta One with <3', 'selfStatus correct')
// TODO comment back in once fixed in core
Expand Down

0 comments on commit 4329aad

Please sign in to comment.