fix #384

[hpk42]

fixed missing events

it's odd that there are three places to add the same info.
in python it's in "const.py" and the you can regenerate automatically with "python const.py" which also excludes typos etc.

anyway, this PR makes desktop work again for me.

[Jikstra]

Very odd, can we somehow auto generate those constants in node.js ?

[hpk42]

here is how we generate event names/numbers from deltachat.h: https://github.com/deltachat/deltachat-core-rust/blob/master/python/src/deltachat/const.py#L94 it goes to "deltachat.h" and scans the file, and then generates the top level part of "const.py". And here is the code that dynamically generates a dictionary from numbers to event names: https://github.com/deltachat/deltachat-core-rust/blob/master/python/src/deltachat/__init__.py#L71 i guess you could do similar things with node. As you have a checkout of deltachat-core-rust you could even use the "const.py" code or we could put it somewhere near the top level. in this way we would only have a single way to turn rust-core events into .js or .py files.

…

On Sat, Oct 05, 2019 at 03:47 -0700, Jikstra wrote: Very odd, can we somehow auto generate those constants in node.js ? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #385 (comment)

[ralphtheninja]

Very odd, can we somehow auto generate those constants in node.js ?

Yes.

https://github.com/deltachat/deltachat-node/blob/master/scripts/generate-constants.js