Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline first: add a hint that the help is also available for relaxed, in-app reading when being offline #645

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

r10s
Copy link
Member

@r10s r10s commented Apr 5, 2023

just came to my mind, pointing out a bit that the help is really available offline - which is not natural in maaaany other apps:

Screenshot 2023-04-06 at 12 56 08

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Response from respost

Check out the page preview at https://staging.delta.chat/645/en/help

en/help.md Outdated
@@ -8,6 +8,8 @@ header: Frequently Asked Questions

## What is Delta Chat?

> In a hurry? You can read this help relaxed at anytime within the app, also without internet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> In a hurry? You can read this help relaxed at anytime within the app, also without internet.
> You can also read this help relaxed at anytime within the app, and it works without internet.

I would remove the 'hurry', and slightly reword.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, the gist was also to be less formal than the rest of the page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker

Copy link
Contributor

@rosano rosano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more helpful to move it before the table of contents so that scrolling isn't necessary.

@r10s
Copy link
Member Author

r10s commented Apr 6, 2023

I think it would be more helpful to move it before the table of contents so that scrolling isn't necessary.

+1 - however, there was an issue with that, but i also did not try hard. wanted some general feedback first, if the hint makes sense at all :)

…eate-local-help.py superfluous as that looks for the first <ul> tag
@r10s
Copy link
Member Author

r10s commented Apr 6, 2023

found a way to move it up, via strings-yaml-file - this has also the advantage that no adaptions are needed for the offline help creation

Copy link
Contributor

@missytake missytake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Was wondering about whether you want that sentence in the in-app-help as well 🙃

@r10s r10s merged commit 83e4da5 into master Apr 6, 2023
@r10s r10s deleted the in-a-hurry branch April 6, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants