allow more generic schemes and add scheme to LinkDestination
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
force-pushed
the
simon/detect-more-uri-schemes
branch
from
4f09af5
to
3708507
Compare
adbenitez
reviewed
Sep 29, 2023
| - all Common Internet Scheme links (containing `//` after scheme) | ||
| - mailto | ||
| - news | ||
| - all Common Internet Scheme links (containing `//` after scheme), |
There was a problem hiding this comment.
some like mailto: and tel: links don't have // after scheme 🤔 the title is not accurate
There was a problem hiding this comment.
look at the lines bellow, tel and mailto are so called generic schemes
adbenitez
approved these changes
Sep 29, 2023
Simon-Laux
force-pushed
the
simon/detect-more-uri-schemes
branch
from
37f3968
to
f8d497c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.