Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request id should be able to be a string #23

Closed
Simon-Laux opened this issue Oct 31, 2022 · 1 comment · Fixed by #27
Closed

request id should be able to be a string #23

Simon-Laux opened this issue Oct 31, 2022 · 1 comment · Fixed by #27

Comments

@Simon-Laux
Copy link
Member

id
An identifier established by the Client that MUST contain a String, Number, or NULL value if included. If it is not included it is assumed to be a notification. The value SHOULD normally not be Null [1] and Numbers SHOULD NOT contain fractional parts [2]

https://www.jsonrpc.org/specification#request_object

the spec says strings can be ids too, but yerpc only supports numbers at the moment.
@Simon-Laux Simon-Laux changed the title request id should be a string request id should be able to be a string Oct 31, 2022
@link2xt
Copy link
Contributor

link2xt commented Nov 8, 2022

Rationale for this is that we want separate entities (backend and frontend) to generate non-conflicting request IDs, e.g. "backend_10", "frontend_15". As a workaround we can generate even IDs in backend and odd IDs in frontend, but a prefix is more maintainable.

Simon-Laux added a commit to Simon-Laux/yerpc that referenced this issue Jan 7, 2023
@Simon-Laux
also allow strings as ids
697a699 
it is a part of the spec and we need it for DC desktop

see deltachat#23

closes deltachat#23
@Simon-Laux Simon-Laux mentioned this issue Jan 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow strings as ids Simon-Laux/yerpc
2 participants
@link2xt @Simon-Laux