Update Sender example to compile #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old version threw compiler error:
```
OemRobertJulDalis1 cannot be resolved or is not a field
```
After changing `OemRobertJulDalis1` to `OemCode.getProductByOemCode("OemRobertJulDalis1")`, that error disappeared. A new one emerged:
```
The method withOemCode(Product) is undefined for the type ArtPollReplyBuilder
```
Root cause is commit 4f1fcd8 (from Sat Apr 25 20:24:42 2020 +0200) where `ArtPollReplyBuilder.withOemCode` was changed to `ArtPollReplyBuilder.withProduct`.
I also added a clarifying comment to ensure the user understands the purpose of the line.
Closed
`artNetSender` and `sender` were mixed up. Sender Example didn't compile.
|
Looks good to me, thank you :) EDIT
The examples work now as of 873faaa so I'm curious why they don't work for you 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
new andexisting testsType of changes ?
Changes by this PR
In README.md, update Sender example from
ArtPollReplyBuilder.withOemCodetoArtPollReplyBuilder.withProductandOemCode.OemRobertJulDalis1toOemCode.getProductByOemCode("OemRobertJulDalis1").I also added a clarifying comment to ensure the user understands the purpose of the line.
Current behaviour
Sender example threw compiler error:
After changing
OemRobertJulDalis1toOemCode.getProductByOemCode("OemRobertJulDalis1"), that error disappeared. A new one emerged:New behaviour
Sender example compiles.
Other information
Root cause is commit 4f1fcd8 (from Sat Apr 25 20:24:42 2020 +0200) where
ArtPollReplyBuilder.withOemCodewas changed toArtPollReplyBuilder.withProduct.I was not able to ensure the example runs as I am still facing other issues while getting the example to work. I will open an issue when I'm ready to report on further problems.