Fix missing quotes in oh-my-zsh install #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deluan
added a commit
that referenced
this pull request
Sep 30, 2022
Based on #18, thanks @chaichontat
|
Thanks @chaichontat , but I didn't get why you commented out the |
|
Oof sorry, I forgot that I was still on the branch that I had submitted a PR for. I was running the script in a user without sudo access, that's why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script currently launches a new shell after oh-my-zsh installation, which is not a typical unattended behavior. Compared to oh-my-zsh's documentation, this script is missing a
""before the--unattendedflag. Adding""resolves this issue.