Skip to content

Commit

Permalink
[Packaging] Move user out of systemd files and add to tarball
Browse files Browse the repository at this point in the history
With the `deluge` user specified in the unit files it ties it to
that user and makes it unavailable for re-use by systemd user instance.

Remove the user and group from the unit files and put them in a separate
`user.conf` file that should be installed as an override file e.g. for
deluged.service this would be placed as follows:

    /etc/systemd/service/deluge.service.d/user.conf

Add the systemd files to the tarball for package maintainers.

Closes: #2034
  • Loading branch information
cas-- committed Jun 8, 2019
1 parent 879a397 commit 212efc4
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,10 @@

## 2.0.2 (WiP)

### Packaging

- Add systemd deluged and deluge-web service files to package tarball (#2034)

### Core

- Fix Python 2 compatiblity issue with SimpleNamespace.
Expand Down
1 change: 1 addition & 0 deletions MANIFEST.in
Expand Up @@ -8,6 +8,7 @@ include version.py
include gen_web_gettext.py

graft docs/man
graft packaging/systemd

include deluge/i18n/*.po
recursive-exclude deluge/i18n *.mo
Expand Down
3 changes: 0 additions & 3 deletions packaging/systemd/deluge-web.service
Expand Up @@ -6,9 +6,6 @@ Wants=deluged.service

[Service]
Type=simple

User=deluge
Group=deluge
UMask=027

ExecStart=/usr/bin/deluge-web -d
Expand Down
2 changes: 0 additions & 2 deletions packaging/systemd/deluged.service
Expand Up @@ -5,8 +5,6 @@ After=network-online.target

[Service]
Type=simple
User=deluge
Group=deluge
UMask=007

ExecStart=/usr/bin/deluged -d
Expand Down
4 changes: 4 additions & 0 deletions packaging/systemd/user.conf
@@ -0,0 +1,4 @@
# Override service user
[Service]
User=deluge
Group=deluge

0 comments on commit 212efc4

Please sign in to comment.