[#3299|GTK] Fix spin_share_ratio min clamps to 0.5

[yuri-sevatz]

In gtkui Settings -> Queue -> "Share Ratio", we cannot set values lower than 0.5.

Attempting to set lower values results in:

* ConfigValueChanged: stop_seed_ratio: 0.5

Deluge Web UI, Deluge Console allow setting values as low as 0.0:

* ConfigValueChanged: stop_seed_ratio: 0.0

Fixed by decreasing the lower clamp in gtkui to match webui.

[yuri-sevatz]

Changes:

• Removed <property name="lower">0</property>, since the default for GtkAdjustment.lower is already 0

This change seems to agree with what glade generates for this, if I set to 0 using their WISIWYG, and then save.

[yuri-sevatz]

CI seems to be broken here, unrelated to change.

[cas--]

If anything it would be the other way around to update Web UI since Deluge has always kept this as a 'be fair' feature

[doadin]

@cas-- I get be fair and you should seed when it comes to public torrents etc etc, however what about private torrents? Do we just not care for the sake of public torrents? We do also realize we can just manually stop, not adding this is just an inconvenience. I hope my point is clear, also just my opinion.

[doadin]

@cas-- I don't want to keep going at this but , you know you could set upload speed to like 0 and max number of seeds to 0 and pretty much get a similar result to just stopping as soon as the torrent is done and upload like nothing aka still leech right? I don't really see how leaving this out makes it much better. Again not to get into this a lot more but if you don't want leachers I think you might need to get stricter but I just don't really see the point anyone can just compile this client or several others to do w.e. they want to. I think most trackers that care monitor it themselves, for this reason. Just some final thoughts, you can ignore.

[yuri-sevatz]

I think @cas-- has already made up their mind.

But I think he's showing a fundamentally flawed security understanding; to think that this can guarantee seeds by writing a client a certain way -- when the bug he's trying to overcome is in the protocol (i.e. only enforceable in the tracker with the help of data from the swarm).

My main gripe with trying to do this in the client: is that if bittorrent doesn't know what leeching is, then deluge won't either. So pretending that we've solved this in deluge by limiting what would otherwise be a normal expression of the bittorrent spec, is somewhat flawed thinking.