Fix plugins still needing specific python version. #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah did I make a mistake in implementing this in 3433a91. Could you mention this in the commit message? The improved fix would be to specify the Environment kwargs so it clear what is being set to None e.g.: |
|
Thanks alot for your reply and review Cas :) I'm sorry but stupidly deleted my forked repo and branch, and tried bring it back by pulling the PR and repushing, which worked but didn't update this here(noob at git and PRs in general), only mine, so I remade new PR and will close this, and obviously not do that mistake again. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.