New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python2 support #325
Drop Python2 support #325
Conversation
b2cd472
to
a5f3b67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are making wholesale changes, we can remove the following from all files:
# -*- coding: utf-8 -*-
Thanks for getting this work started. Maybe look at using this: https://github.com/asottile/pyupgrade with |
+1 for using https://github.com/asottile/pyupgrade with |
9b87e9f
to
9cfeee8
Compare
Do you want to add it permanently to the linting process? |
What I would suggest is that this PR is wrapped up as is and we merge it. So things to finalise for this PR:
Then create a second PR that uses pyupgrade since that will be another huge changeset. Adding pyupgrade to pre-commit is helpful since if added as a pre-commit
|
CHANGELOG.md
Outdated
### Codebase | ||
|
||
- Dropped support for Python 2 | ||
|
||
## 2.0.6 (WIP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to remove this since we'll add it back when needed
a4793f5
to
d062b6c
Compare
* Removed all __future__ imports from code * Removed all six dependencies * Removed all future_builtins imports * Removed all Python 2 related code Closes: deluge-torrent#325
As python2 is already at its EOF state, we can drop all of the support to it.
This PR will contain all of the changes to this end.
Plan:
__future__
importssix
dependencyfuture_builtins
importsf-strings
only?)If you know about any other things to change, please write.