Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double colon route issue (#219) for 4.x branch #223

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

emfomy
Copy link

@emfomy emfomy commented Dec 24, 2021

Hi, although the double colon route issue (#219) is already fixed by (#220) and released in v5.1.1.
However, since I'm using fastify, which is currently using the 4.x version of find-my-way.
So I decided to cherry-pick #220 and create a PR.

Related Issue

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit 8101c88 into delvedor:4.x Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants