change path for short static route bench #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Dec 25, 2021
| @@ -14,7 +14,7 @@ const suite = Benchmark.Suite() | |||
| const FindMyWay = require('./') | |||
|
|
|||
| const findMyWay = new FindMyWay() | |||
| findMyWay.on('GET', '/', () => true) | |||
There was a problem hiding this comment.
please retain this route
ivan-tymoshenko
force-pushed
the
change-path-for-short-static-route-bench
branch
from
09c60db
to
9e12efc
Compare
ivan-tymoshenko
force-pushed
the
change-path-for-short-static-route-bench
branch
from
9e12efc
to
2160f2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to optimize the find method, I was confused. I made changes that were supposed to speed up the algorithm, but they only made it slower for short static routes. It turns out that
/route is a super special case, cause you get the results immediately from the root node without using the searching algorithm. If you try to search the path that contains only one more symbol/a, you will get at least twice a worse result. IMHO, when we test the find method we want to see results for some average, but not for the extreme case.