-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wildcard routes fallback #230
Merged
mcollina
merged 3 commits into
delvedor:main
from
ivan-tymoshenko:fix-wildcard-routes-fallback
Feb 1, 2022
Merged
Fixed wildcard routes fallback #230
mcollina
merged 3 commits into
delvedor:main
from
ivan-tymoshenko:fix-wildcard-routes-fallback
Feb 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-tymoshenko
force-pushed
the
fix-wildcard-routes-fallback
branch
from
January 11, 2022 16:21
288c122
to
d73aaf0
Compare
ivan-tymoshenko
force-pushed
the
fix-wildcard-routes-fallback
branch
from
January 12, 2022 09:03
d73aaf0
to
5988fcf
Compare
mcollina
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Did you run the benchmarks? |
mcollina
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Eomm
reviewed
Jan 15, 2022
@Eomm ping |
Eomm
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #227
Depends on #229