Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wildcard routes fallback #230

Merged

Conversation

ivan-tymoshenko
Copy link
Collaborator

Fixed #227
Depends on #229

@ivan-tymoshenko
Copy link
Collaborator Author

@delvedor @mcollina All requests that are needed for this have been merged. Please take a look at it when you have some time.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm
Copy link
Contributor

Eomm commented Jan 14, 2022

Did you run the benchmarks?
Could you share the results?

@ivan-tymoshenko
Copy link
Collaborator Author

Benchmark results

Main branch

main

Current branch

Снимок экрана 2022-01-14 в 20 10 56

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test/issue-28.test.js Outdated Show resolved Hide resolved
@mcollina
Copy link
Collaborator

@Eomm ping

@mcollina mcollina merged commit efbc8a6 into delvedor:main Feb 1, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the fix-wildcard-routes-fallback branch April 17, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard node should be checked for constraints
3 participants