Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run benchmarks in separate threads #233

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Run benchmarks in separate threads #233

merged 1 commit into from
Jan 18, 2022

Conversation

ivan-tymoshenko
Copy link
Collaborator

Fixed #232

@ivan-tymoshenko ivan-tymoshenko changed the title Run benchmarks is separate threads Run benchmarks in separate threads Jan 5, 2022
delvedor
delvedor reviewed Jan 9, 2022
View reviewed changes
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! @mcollina any thoughts?

@ivan-tymoshenko ivan-tymoshenko force-pushed the run-benchmarks-in-separate-threads branch from b7bb56a to 6afa612 Compare January 12, 2022 21:10
@ivan-tymoshenko
Copy link
Collaborator Author

ivan-tymoshenko commented Jan 12, 2022 •
edited

Benchmark results:

Main branch:

main

Main branch (shuffled):

Снимок экрана 2022-01-12 в 23 40 58

Current branch:

threads

Current branch (shuffled):

Снимок экрана 2022-01-12 в 23 12 59

mcollina
mcollina approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Collaborator

This code is quite good!

@ivan-tymoshenko ivan-tymoshenko force-pushed the run-benchmarks-in-separate-threads branch from 6afa612 to 69c1367 Compare January 18, 2022 16:54
@ivan-tymoshenko ivan-tymoshenko marked this pull request as ready for review January 18, 2022 16:56
@mcollina mcollina merged commit 5845290 into delvedor:main Jan 18, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the run-benchmarks-in-separate-threads branch April 17, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmark results depend on their order
3 participants
@ivan-tymoshenko @mcollina @delvedor