Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize constraints' strategies #246

Merged
merged 1 commit into from Apr 11, 2022
Merged

Optimize constraints' strategies #246

merged 1 commit into from Apr 11, 2022

Conversation

ivan-tymoshenko
Copy link
Collaborator

@ivan-tymoshenko ivan-tymoshenko commented Apr 9, 2022 •
edited

I optimized the version constraint strategy and removed empty and delete methods from the strategy interface. I don't know why we need them.

@ivan-tymoshenko
Copy link
Collaborator Author

Main branch

main

Current branch

current

@ivan-tymoshenko ivan-tymoshenko marked this pull request as ready for review April 9, 2022 18:03
mcollina
mcollina reviewed Apr 9, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a semver-major change

@ivan-tymoshenko
Copy link
Collaborator Author

ivan-tymoshenko commented Apr 9, 2022 •
edited

@mcollina Why do you think so? I just removed unused methods. I can return them back if you tell me why we need them there.

RafaelGSS
RafaelGSS approved these changes Apr 9, 2022
View reviewed changes
Copy link
Contributor

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive results in constrained routes. LGTM.

mcollina
mcollina approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, those methods are not really exposed!

@mcollina mcollina merged commit 51c341a into delvedor:main Apr 11, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the optimize-constraints-stategies branch April 17, 2022 14:16
@ivan-tymoshenko ivan-tymoshenko mentioned this pull request May 22, 2022
Merged
4 tasks
@matthyk matthyk mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan-tymoshenko @mcollina @RafaelGSS