Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison of benchmarks results on different branches #268

Merged

Conversation

ivan-tymoshenko
Copy link
Collaborator

@ivan-tymoshenko ivan-tymoshenko commented Apr 30, 2022

Added two new commands for benchmarking.

  • bench:cmp - allows to choose two branches, run benchmarks and compare results.
  • bench:cmp:ci - runs bench:cmp with default params current branch as a "new feature" branch and main branch.

If the difference between benchmarks is more or less than the threshold = 5%, it will emphasize the benchmark result with green or red color.

selecting branches:

Снимок экрана 2022-04-30 в 21 44 30

bench:cmp:ci output example:

Снимок экрана 2022-04-30 в 21 39 41

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! LGTM!

@mcollina mcollina merged commit 2608f2b into delvedor:main Apr 30, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the add-benchmarks-brench-comparison branch April 30, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants