Fix regression issue #17 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoscopelliti
commented
Oct 1, 2017
| @@ -78,7 +78,7 @@ Router.prototype.on = function (method, path, handler, store) { | |||
|
|
|||
| if (isRegex && (i === len || path.charCodeAt(i) === 47)) { | |||
| nodeType = 3 | |||
| } else if (i < len) { | |||
| } else if (i < len && path.charCodeAt(i) !== 47) { | |||
There was a problem hiding this comment.
The missing of the check against path.charCodeAt(i) caused that every parametric part of the url that didn't contain a regular expression, and was followed by another part of the url, was treated as a multi-parametric part.
|
LGTM |
|
Landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression reported in #27 (comment).
@AVVS, I'm sorry for the leaked breaking change.