Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add findRoute and hasRoute methods #337

Merged
merged 2 commits into from Oct 6, 2023
Merged

feat: add findRoute and hasRoute methods #337

merged 2 commits into from Oct 6, 2023

Conversation

ivan-tymoshenko
Copy link
Collaborator

@ivan-tymoshenko ivan-tymoshenko commented Sep 24, 2023

Close #332
Issue in fastify: fastify/fastify#4866

@mcollina
Copy link
Collaborator

What's missing?
Could you skip Node.js v14 on Windows?

@ivan-tymoshenko
Copy link
Collaborator Author

I wan't to remove the code duplication. Will be ready to merge this week.

@ivan-tymoshenko ivan-tymoshenko changed the title feat: add has method feat: add a hasRoute method Oct 5, 2023
@ivan-tymoshenko ivan-tymoshenko marked this pull request as ready for review October 5, 2023 19:04
@ivan-tymoshenko ivan-tymoshenko marked this pull request as draft October 5, 2023 19:24
@ivan-tymoshenko ivan-tymoshenko marked this pull request as ready for review October 5, 2023 20:06
@ivan-tymoshenko ivan-tymoshenko changed the title feat: add a hasRoute method feat: add findRoute and hasRoute methods Oct 5, 2023
@mcollina
Copy link
Collaborator

mcollina commented Oct 5, 2023

please drop windows and node v14, it's broken on Gha

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a78e810 into main Oct 6, 2023
23 checks passed
@mcollina mcollina deleted the add-has-method branch October 6, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add has method
2 participants